Skip to content

Fix redundant rows.Close() calls in queryCode.tmpl #3856

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions internal/codegen/golang/templates/stdlib/queryCode.tmpl
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,9 +53,6 @@ func (q *Queries) {{.MethodName}}(ctx context.Context, {{ dbarg }} {{.Arg.Pair}}
}
items = append(items, {{.Ret.ReturnName}})
}
if err := rows.Close(); err != nil {
return nil, err
}
if err := rows.Err(); err != nil {
return nil, err
}
Expand Down
3 changes: 0 additions & 3 deletions internal/endtoend/testdata/any/stdlib/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

3 changes: 0 additions & 3 deletions internal/endtoend/testdata/array_in/stdlib/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

3 changes: 0 additions & 3 deletions internal/endtoend/testdata/array_text/stdlib/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

Some generated files are not rendered by default. Learn more about how customized files appear on .

12 changes: 0 additions & 12 deletions internal/endtoend/testdata/between_args/mysql/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

Some generated files are not rendered by default. Learn more about how customized files appear on .

Some generated files are not rendered by default. Learn more about how customized files appear on .

Some generated files are not rendered by default. Learn more about how customized files appear on .

3 changes: 0 additions & 3 deletions internal/endtoend/testdata/case_text/stdlib/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

Some generated files are not rendered by default. Learn more about how customized files appear on .

3 changes: 0 additions & 3 deletions internal/endtoend/testdata/cast_null/stdlib/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

3 changes: 0 additions & 3 deletions internal/endtoend/testdata/cast_param/sqlite/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

3 changes: 0 additions & 3 deletions internal/endtoend/testdata/citext/stdlib/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

6 changes: 0 additions & 6 deletions internal/endtoend/testdata/coalesce/mysql/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

Some generated files are not rendered by default. Learn more about how customized files appear on .

6 changes: 0 additions & 6 deletions internal/endtoend/testdata/coalesce/sqlite/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

3 changes: 0 additions & 3 deletions internal/endtoend/testdata/coalesce_as/mysql/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

Some generated files are not rendered by default. Learn more about how customized files appear on .

3 changes: 0 additions & 3 deletions internal/endtoend/testdata/coalesce_as/sqlite/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on .

Some generated files are not rendered by default. Learn more about how customized files appear on .

Some generated files are not rendered by default. Learn more about how customized files appear on .

Loading
Loading