Skip to content

allow JDK 13/14 build (on 1.0.x branch) #246

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

Sign up for

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2019
Merged

allow JDK 13/14 build (on 1.0.x branch) #246

merged 1 commit into from
Oct 23, 2019

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Oct 23, 2019•
edited
Loading

note that the Travis-CI changes don't make the JDK 6 build work, but they do allow the JDK 8 one to run, at least

the context for this is scala/community-build#984

@SethTisueSethTisue force-pushed the allow-building-on-jdk14 branch 3 times, most recently from c574877 to 205fabf Compare October 23, 2019 01:31
@SethTisue
allow JDK 13/14 build
d99be7e
note that the Travis-CI changes don't make the JDK 6 build
work, but they do allow the JDK 8 one to run
@SethTisueSethTisue force-pushed the allow-building-on-jdk14 branch from 205fabf to d99be7e Compare October 23, 2019 01:37
@SethTisueSethTisue changed the title allow JDK 13/14 build allow JDK 13/14 build (on 1.0.x branch) Oct 23, 2019
@SethTisue
Copy link
Member Author

the JDK 8 build still fails with

[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: com.typesafe#sbt-mima-plugin;0.1.14: not found
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::

which I don't understand, but in any case this PR doesn't make the Travis-CI situation any worse, so, merging regardless

@SethTisueSethTisue merged commit c4c97ba into scala:1.0.x Oct 23, 2019
@SethTisue
Copy link
Member Author

maybe it couldn't find mima because of lightbend-labs/mima#422

@SethTisueSethTisue deleted the allow-building-on-jdk14 branch October 23, 2019 15:36
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@SethTisue