Apply monkey es for SQL Server connections only (#933) #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Recent versions of Rails support multiple database connections within the same app. It is possible for these connections to use different adapters. For example, one adapter may use SQL Server, and another uses PostgreSQL. This gem applies some monkey es to ActiveRecord for SQL Server compatibility. These es could break other adapters, though, in a multiple-database scenario. This commit modifies the es so that they are applied only if the connection is SQL Server. If not, the original ActiveRecord implementation (`super`) is used instead. Fixes #929
Hi @aidanharan, @metaskills, @annaswims, @wbond, @wpolicarpo 👋 Thank you for the fantastic gem! Could you please release this fix to the 6.0+ version, too? |
@djezzzl I just released v6.0.3 of the gem to Rubygems with this fix. |
Thank you very much, @aidanharan! Have a great week! |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a cherry-picked fix that I'm kindly asking you to release for the 6.0+ version.
The original message
Recent versions of Rails support multiple database connections within the same app. It is possible for these connections to use different adapters. For example, one adapter may use SQL Server, and another uses PostgreSQL.
This gem applies some monkey es to ActiveRecord for SQL Server compatibility. These es could break other adapters, though, in a multiple-database scenario.
This commit modifies the es so that they are applied only if the connection is SQL Server. If not, the original ActiveRecord implementation (
super) is used instead.Fixes #929