Fix hook method that allows custom connection configuration #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
5342202 to 5d7fadc Compare owst commented Mar 8, 2023
The change looks reasonable to me - thanks! |
aidanharan added a commit that referenced this pull request Mar 9, 2023
…ation-7.0 Fix hook method that allows custom connection configuration
KDGundermann pushed a commit to KDGundermann/activerecord-sqlserver-adapter that referenced this pull request Mar 14, 2023
…ection-configuration-7.0 Fix hook method that allows custom connection configuration
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The method
configure_connectionwas meant to be a hook method to allow custom connection configuration. However, the method was implemented in the adapter to perform the default connection configuration. I have extracted the default connection configuration to it's own method so that the hook method is available again for custom configuration.This allows users to implement
configure_connectionwithout having to re-implement the default configuration or call super to call the adapter's implementation of the method.This fixes issue #950
Note: The fix will later be backported to the
6-1-stablebranch.