[PBCKP-334] Unified segno code for any fork #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In fact, any fork (not only MAIN_FORKNUM) can have multiple segments. tags: ptrack
| else | ||
| pfl->segno = 0; | ||
| /* Parse segno */ | ||
| segpath = strstr(de->d_name, "."); |
There was a problem hiding this comment.
Maybe use strchr since we're touching this lines ?
funny-falcon approved these changes Nov 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 89.15% 87.91% -1.24%
==========================================
Files 2 2
Lines 424 422 -2
==========================================
- Hits 378 371 -7
- Misses 46 51 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In fact, any fork (not only MAIN_FORKNUM) can have multiple segments.
tags: ptrack