Don't spray XML parser errors to stderr #2930
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Hello @erkia , Could you provide a couple of examples of such messages? Ideally include xml bodies to reproduce them and whether any special configuration is required to reproduce the issue (e.g. higher LogLevel in the apache config). |
marcstern commented Feb 1, 2024
Non-standard messages in error log are not clean, but no message at all isn't good either. |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, all XML parser errors are written to stderr, which in case of Apache means that the messages end up randomly in error_log, unformatted.
This pull request adds custom XML error handling function, which just discards all the messages at the moment.