Skip to content

Update aws nlb manifests installation #543

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Open
wants to merge 1 commit into
base: ngf-feature-cp-dp-split
Choose a base branch
from

Conversation

bjee19
Copy link

@bjee19 bjee19 commented May 8, 2025

There is no longer an aws-nlb deploy.yaml file, so we need to update the manifests installation and give some information on setting annotations in the Gateway.

Problem: There is no longer an aws-nlb deploy.yaml file, so we need to update documentation.

Solution: Update the documentation and give information on setting annotations on the Gateway.

Testing: Checked with make watch

Related with: nginx/nginx-gateway-fabric#3362

Closes

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@bjee19bjee19 requested a review from a team as a code owner May 8, 2025 22:26
@bjee19bjee19 requested a review from a team May 8, 2025 22:26
@github-actions-actions bot added documentationImprovements or additions to documentationproduct/ngfIssues related to NGINX Gateway Fabriclabels May 8, 2025
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
documentationImprovements or additions to documentationproduct/ngfIssues related to NGINX Gateway Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
@bjee19