Check GetResourceIdentitySchemas diagnostics and return early #36999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Do we want to backport this to 1.12.0 or keep it for 1.12.1? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds an early return in the provider’s GetProviderSchema function when identity diagnostics contain errors. It also introduces new unit tests in both the plugin and plugin6 packages to verify that behavior.
- Early return in GetProviderSchema if identity diagnostics indicate an error.
- New tests in internal/plugin6/grpc_provider_test.go and internal/plugin/grpc_provider_test.go covering the error diagnostic scenario.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/plugin6/grpc_provider.go | Adds a check for error diagnostics from GetResourceIdentitySchemas and early returns. |
| internal/plugin6/grpc_provider_test.go | Introduces a unit test validating error diagnostic handling. |
| internal/plugin/grpc_provider.go | Adds similar error checks and early return. |
| internal/plugin/grpc_provider_test.go | Introduces a unit test validating error diagnostic handling. |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a check if
GetResourceIdentitySchemasreturned diagnostics and returns early if there are anyTarget Release
1.12.x
CHANGELOG entry