Skip to content

Fix Runtime punycode Deprecation Error (#2662) #2673

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davnotdev
Copy link

@davnotdev davnotdev commented Jan 8, 2025

Addresses #2662.

After the builtin punycode implementation was deprecated, quicktype now crashes at runtime from a deprecation error. This fix temporarily overrides whatwg-url to version ^13.0.0, the earliest version that properly uses a userspace punycode implementation.

whatwg-url is a dependency of node-fetch 2.x which is a dependency of cross-fetch. In the future, updating cross-fetch should fix the issue without having to override whatwg-url once this issue is addressed.

Also, further work should be done to update @vscode/vsce, eslint-config-canonical, and ajv These are dev dependencies, so they should not affect runtime, but are still prone to the punycode error.

@aguynamedben
Copy link

Thank you for this PR. +1. Workaround until this is merged is to add this to package.json.

  "//": "We can remove resolutions once this is merged: https://.com/glideapps/quicktype/pull/2673",
  "resolutions": {
    "whatwg-url": "^13.0.0"
  }

Copy link

@aguynamedben aguynamedben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants