add gfbf as subtoolchain of foss #4143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bartoldeman previously approved these changes Dec 16, 2022
I've restarted the container tests. |
akesandgren previously requested changes Dec 16, 2022
| @@ -40,7 +41,7 @@ | |||
| class Foss(Gompi, OpenBLAS, FlexiBLAS, ScaLAPACK, Fftw): | |||
| """Compiler toolchain with GCC, OpenMPI, OpenBLAS, ScaLAPACK and FFTW.""" | |||
| NAME = 'foss' | |||
| SUBTOOLCHAIN = [Gompi.NAME, Golf.NAME] | |||
| SUBTOOLCHAIN = [Gompi.NAME, Golf.NAME, Gfbf.NAME] | |||
There was a problem hiding this comment.
Need tio add Golf and Gfbf calls to the banned_linked_shaed_libs too
There was a problem hiding this comment.
@akesandgren fixed in 26e3e22
…n in foss toolchain
…fbf toolchains, already handled via separate toolchain components like OpenBLAS/FlexiBLAS
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)Required for easybuilders/easybuild-easyconfigs#16912, so
SciPy-bundle/2022.11-gfbf-2022.10is considered as dependency formpi4py/3.1.4-foss-2022.10