add support for setting environment variables via 'pushenv' with modextravars #4030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| raise EasyBuildError("Required key 'value' is missing in dict that specifies how to set $%s: %s", | ||
| env_var_name, env_var_val) | ||
| else: | ||
| raise EasyBuildError("Incorrect value type for setting $%s environment variable (%s): %s", |
There was a problem hiding this comment.
Should this include list of valid types?
There was a problem hiding this comment.
Yes, that would be helpful indeed, I'll change that, thanks for the suggestion!
Tests are failing when using Lmod as modules tool + Tcl as module file syntax, which is due to a bug in Lmod I think; see upstream issue I opened at TACC/Lmod#584 . |
…v in Tcl module files)
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use case here is internal, but it's basically an environment variable we want to define via
pushenvthrough a custom hook implementation.General support for
pushenvis useful, since it avoids the need to resort tomodluafooter...