Allow basic compiler modulenames to be specified as keys in optarch. #2387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Examples: 'GCCcore', 'icc', 'ifort'. They will be considered before
the compiler family ('Intel', etc).@damianam this is pretty much doing what we discussed, considering the compiler module names as keys before the family. |
damianam requested changes Jan 31, 2018
| # no option for this compiler | ||
| else: | ||
| if isinstance(optarch, dict): |
There was a problem hiding this comment.
I find it odd the recheck for optarch being a dict. It makes sense, but I'd clarify it in the comment above. Something like:
# optarch hasn't changed, it is still a dict, which means that there is no option for this compiler
| if optarch[current_compiler] == OPTARCH_GENERIC: | ||
| use_generic = True | ||
| else: | ||
| # first try module names, than the family in optarch |
damianam approved these changes Feb 1, 2018
lgtm! |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Examples: 'GCCcore', 'icc', 'ifort'. They will be considered before
the compiler family ('Intel', etc).