Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I noticed some builds printing fatal errors, but exiting with status 0 and "Found 0 issues."
It looks like this is because the exception flow changed in php7:
https://trowski.com/2015/06/24/throwable-exceptions-and-errors-in-php7/
http://php.net/manual/en/language.errors.php7.php
The main point being there is now a separation between
Exception
andError
objects:Rescuing the globally namespaced
\Throwable
will also rescueErrors
such as thisTypeError
. I can verify this leads to the correct behavior (the error message is also printed in our format from the catch block):I will make the same fix in
phpcodesniffer
assuming this fix goes well.