fix: let the upload run when no board is selected #2387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
IDE2 must not disable the upload from the UI when no board is selected. Otherwise, IDE2 does not receive the `no FQBN` error from the CLI and cannot cannot suggest selecting a board via the `Tools` > `Board` menu. Closes #1714 Signed-off-by: Akos Kitta <[email protected]>
giacomocusinato approved these changes Feb 23, 2024
CLAassistant commented Apr 1, 2024
Akos Kitta seems not to be a user. You need a account to be able to sign the CLA. If you have already a account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation
IDE2 must not disable the upload from the UI when no board is selected. Otherwise, IDE2 does not receive the
no FQBNerror from the CLI and cannot suggest selecting a board via theTools>Boardmenu.Change description
Other information
Closes #1714
Reviewer checklist