Skip to content

Update Gradle, Kotlin, library version #37

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Amlsakr
Copy link
Collaborator

No description provided.

@AbdAllahAbdElFattah13
Copy link
Collaborator

AbdAllahAbdElFattah13 commented Aug 5, 2022

I have a couple of points:

  • Since we don't have some integration or end-to-end or ui tests, do we run a smoke test even manually for the changes?
  • generally speaking, this kind of upgrade should be carried out gradually بالتدريج as in bigger apps upgrading everything at once can introduce some unintentional issues (either due to compatibility issues or even some breaking changes). I understand that this not a huge app, but I thought to share my thoughts to raise awareness. :))

Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants