Skip to content

benchmarks: Hide data/ folder #68

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024
Merged

benchmarks: Hide data/ folder #68

merged 1 commit into from
Feb 28, 2024

Conversation

homersimpsons
Copy link
Contributor

@homersimpsons homersimpsons commented Feb 25, 2024

The data/ folder contains raw data.

It should not be displayed in the tabs, and its *.cbor files should not be rendered

Capture d'écran 2024-02-25 020632

Implementation:

  • Previously we were listing the directory names to use
  • Now I'm listing criterion/<directory>

Alternatively I can continue listing the directory names, but then I should exclude the .cbor files, which will lead to far more false-positive files.

Fixes #66

This Pull Request was made possible thanks to #67 (thanks @olivierlemasle)

  • I do not like liquid template engine, it feels like so much things are missing (using | split: ", " to create an array ?!, error with concat on line 29 while there is no concat on this line ?!, I used an inexistant spit filter and the engine did not report it to me ?!)
  • feel free to discuss the changes
  • looks like we are not using version 5 so I cannot use liquid tag https://shopify..io/liquid/tags/template/#liquid

The `data/` folder contains raw data.

It should not be displayed in the tabs, and its `*.cbor` files should not be rendered
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowoneyouknowone merged commit beb7d04 into RustPython:master Feb 28, 2024
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark images are not displayed
2 participants