Skip to content

fix: linting workflow #499

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025
Merged

fix: linting workflow #499

merged 3 commits into from
Feb 24, 2025

Conversation

SRWieZ
Copy link
Member

@SRWieZ SRWieZ commented Feb 21, 2025

Since main is now protected, this workflow ceased to function.

Proposing an alternative where it only check linting error on main and fix them on pull requests

Same as NativePHP/electron#173

@SRWieZSRWieZ force-pushed the fix-linting-workflow branch from 8401916 to 1650766 Compare February 21, 2025 20:16
@SRWieZSRWieZ requested a review from a team February 22, 2025 16:07
Copy link
Contributor

@gwleuverink gwleuverink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart 👍

@SRWieZ
Copy link
Member Author

You reviewed it but did not approve it, is that on purpose? ^^

@SRWieZSRWieZ merged commit cea2b0d into main Feb 24, 2025
3 of 23 checks passed
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants