Adversary being able to produce new blocks after an invalid block #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
config/default.js Outdated
| @@ -43,6 +43,7 @@ module.exports = { | |||
| WEBSOCKET_PORT: process.env.WEBSOCKET_PORT || 8080, | |||
| WEBSOCKET_PING_TIME: 15000, | |||
| ZOKRATES_WORKER_HOST: process.env.ZOKRATES_WORKER_HOST || 'worker', | |||
| STOP_QUEUE_AFTER_INVALID_BLOCK: process.env.STOP_QUEUE_AFTER_INVALID_BLOCK === 'true', | |||
There was a problem hiding this comment.
I think the default operation is STOP. Can we then change variable to NONSTOP functionality by default being false? If this variable is not defined, then we will stop queues. This will be easier when deploying so that i don't need to define this variable unless i want to test. Else, you are forcing me to include it once this PR is merged.
| await enqueueEvent(() => logger.info('Stop Until Rollback'), 2); | ||
| logger.info(`STOP_QUEUE_AFTER_INVALID_BLOCK: ${config.STOP_QUEUE_AFTER_INVALID_BLOCK}`); | ||
| // stop queue based on STOP_QUEUE_AFTER_INVALID_BLOCK option | ||
| if (config.STOP_QUEUE_AFTER_INVALID_BLOCK) |
There was a problem hiding this comment.
So, here it forces me to have this variable defined in order to have the old functionality. So, if this NONSTOP var is not defined, it will be false, and then the operation is the same as we had earlier.
if (!config.NONSTOP_QUEUE_AFTER_INVALID_BLOCK) {
await enqueueEvent(() => logger.info('Stop Until Rollback'), 2);
}
3be134c to 1c7de25 Compare druiz0992 approved these changes Jun 30, 2022
Removed code from optimist and have done the transpilation for the adversary to include the code. |
IlyasRidhuan approved these changes Jul 1, 2022
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #770, #776
Description
We have to run adversary being able to propose blocks after an invalid block and run some tests to check all is ok when rolling back invalid and subsequent blocks.
Work
STOP_QUEUE_AFTER_INVALID_BLOCKin optimist to stop or continue producing blocks after an invalid block is detected.