Skip to content

David/staging #514

New issue

Have a question about this project? Sign up for a free account to open an issue and contact its maintainers and the community.

Sign up for

By clicking “Sign up for ”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on ? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 4, 2022
Merged

David/staging #514

merged 14 commits into from
Mar 4, 2022

Conversation

druiz0992
Copy link
Contributor

@druiz0992 druiz0992 commented Feb 18, 2022•
edited
Loading

Close #543

Minor changes for staging/production deployments. No change required or done for existing deployments.

  • config/default.js : optimistBaseUrl, optimistWsUrl and web3WsUrl now depend on DOMAIN_NAME
  • nightfall-deployer/truffle-config.js : Added staging and mainnet networks. I am using staging temporarily which uses ganache
  • added /healthcheck endpoint to propsoser. I need this because in AWS deployments will bring container down if there isn't an endpoint where healthcheck can be checked
  • modified common-files/utils/mongo.mjs to work with both mongoDb and DocumentDb.
  • DocumentDb is accessed via some stored secrets in AWS secret manager. Code needs to be part of nightfall.

@druiz0992druiz0992 requested review from Westlad and ChaitanyaKonda and removed request for Westlad and ChaitanyaKonda February 18, 2022 14:56
@ChaitanyaKondaChaitanyaKonda added the DNMDo not mergelabel Feb 21, 2022
@druiz0992druiz0992 removed the DNMDo not mergelabel Feb 21, 2022
@druiz0992druiz0992 requested a review from daveroga March 1, 2022 09:07
@druiz0992druiz0992 mentioned this pull request Mar 1, 2022
Merged
@druiz0992druiz0992 self-assigned this Mar 2, 2022
@druiz0992druiz0992 requested a review from daveroga March 2, 2022 10:45
@druiz0992druiz0992 added the One more approval neededOne reviewer has approved this PR but another is neededlabel Mar 3, 2022
ChaitanyaKonda
ChaitanyaKonda approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@ChaitanyaKonda ChaitanyaKonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes in this PR also exist in this other PR

Requested some changes in the other PR.
Approving this one

@druiz0992druiz0992 merged commit c7bef62 into master Mar 4, 2022
@druiz0992druiz0992 deleted the david/staging branch March 4, 2022 09:55
@druiz0992druiz0992 removed the One more approval neededOne reviewer has approved this PR but another is neededlabel Mar 7, 2022
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Reviewers

@ChaitanyaKonda ChaitanyaKonda ChaitanyaKonda approved these changes

@Westlad Westlad Awaiting requested review from Westlad

@daveroga daveroga Awaiting requested review from daveroga

@signorecello signorecello Awaiting requested review from signorecello

Assignees

@druiz0992 druiz0992

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace MongoDB with DocumentDB in staging and prod
3 participants
@druiz0992 @ChaitanyaKonda @daveroga