Improve CodeFormatter efficiency (#272)

* remove unnecessary successResponse * avoid calling getResponseContext unnecessarily * update changelog * avoid calling getSchemaContext unnecessarily * allow onlySuccessResponses to be true when there are multiple success responses * restore previous behaviour * remove no longer true changelog

Author: zntfdr

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Next Version
 
+### Changed
+- Improved `CodeFormatter` efficiency #272 @zntfdr
+
 ## 4.5.0
 
 ### Changed

Sources/SwagGenKit/CodeFormatter.swift

@@ -165,17 +165,21 @@ public class CodeFormatter {
 context["isFile"] = schema.isFile
 
 if modelInheritance {
-context["requiredProperties"] = schema.requiredProperties.map(getPropertyContext)
-context["optionalProperties"] = schema.optionalProperties.map(getPropertyContext)
-context["properties"] = schema.properties.map(getPropertyContext)
+let requiredPropertiesContext = schema.requiredProperties.map(getPropertyContext)
+let optionalPropertiesContext = schema.optionalProperties.map(getPropertyContext)
+context["requiredProperties"] = requiredPropertiesContext
+context["optionalProperties"] = optionalPropertiesContext
+context["properties"] = requiredPropertiesContext + optionalPropertiesContext
 context["enums"] = schema.enums.map(getEnumContext)
 context["schemas"] = schema.properties.compactMap { property in
 getInlineSchemaContext(property.schema, name: property.name)
 }
 } else {
-context["requiredProperties"] = schema.inheritedRequiredProperties.map(getPropertyContext)
-context["optionalProperties"] = schema.inheritedOptionalProperties.map(getPropertyContext)
-context["properties"] = schema.inheritedProperties.map(getPropertyContext)
+let inheritedRequiredPropertiesContext = schema.inheritedRequiredProperties.map(getPropertyContext)
+let inheritedOptionalPropertiesContext = schema.inheritedOptionalProperties.map(getPropertyContext)
+context["requiredProperties"] = inheritedRequiredPropertiesContext
+context["optionalProperties"] = inheritedOptionalPropertiesContext
+context["properties"] = inheritedRequiredPropertiesContext + inheritedOptionalPropertiesContext
 context["enums"] = schema.inheritedEnums.map(getEnumContext)
 context["schemas"] = schema.inheritedProperties.compactMap { property in
 getInlineSchemaContext(property.schema, name: property.name)
@@ -310,15 +314,14 @@ public class CodeFormatter {
 // Responses
 
 let responses = operation.responses
-let successResponse = responses.first { $0.successful }
 let successResponses = responses.filter { $0.successful }.map(getResponseContext)
 let failureResponses = responses.filter { !$0.successful }.map(getResponseContext)
 
-context["responses"] = responses.map(getResponseContext)
+context["responses"] = successResponses + failureResponses
 context["successResponse"] = successResponses.first
-context["successType"] = successResponse.flatMap(getResponseContext)?["type"]
-context["defaultResponse"] = responses.first { $0.statusCode == nil }.flatMap(getResponseContext)
-context["onlySuccessResponses"] = successResponse != nil && responses.count == 1
+context["successType"] = successResponses.first?["type"]
+context["defaultResponse"] = failureResponses.first { $0["statusCode"] == nil }
+context["onlySuccessResponses"] = !successResponses.isEmpty && responses.count == 1
 context["alwaysHasResponseType"] = responses.filter { $0.response.value.schema != nil }.count == responses.count
 
 let successTypes = successResponses.compactMap { $0["type"] as? String }