Fix tests (#1055)

Author: aidanharan

./workflows/ci.yml

@@ -13,7 +13,9 @@ jobs:
 strategy:
 fail-fast: false
 matrix:
-ruby: [2.5.9, 2.6.7, 2.7.3, 3.0.1]
+ruby:
+- 2.7.5
+- 3.0.3
 
 steps:
 - name: Checkout code

Gemfile

@@ -7,9 +7,10 @@ git_source(:) { |repo| "https://.com/#{repo}.git" }
 gemspec
 
 gem "bcrypt"
-gem "pg", ">= 0.18.0"
+gem "pg", "~> 1.3"
 gem "sqlite3", "~> 1.4"
 gem "tzinfo-data", platforms: [:mingw, :mswin, :x64_mingw, :jruby]
+gem "minitest", ">= 5.15.0", "< 5.16"
 
 if ENV["RAILS_SOURCE"]
 gemspec path: ENV["RAILS_SOURCE"]

appveyor.yml

@@ -5,10 +5,10 @@ build: off
 matrix:
 fast_finish: true
 allow_failures:
-- ruby_version: "25"
-- ruby_version: "26"
-- ruby_version: "27"
 - ruby_version: "27-x64"
+- ruby_version: "27"
+- ruby_version: "30"
+- ruby_version: "30-x64"
 services:
 - mssql2014
 
@@ -38,9 +38,7 @@ environment:
 CI_AZURE_PASS:
 secure: cSQp8sk4urJYvq0utpsK+r7J+snJ2wpcdp8RdXJfB+w=
 matrix:
-- ruby_version: "25-x64"
-- ruby_version: "25"
-- ruby_version: "26-x64"
-- ruby_version: "26"
 - ruby_version: "27-x64"
 - ruby_version: "27"
+- ruby_version: "30"
+- ruby_version: "30-x64"

test/cases/coerced_tests.rb

@@ -1088,7 +1088,8 @@ class YamlSerializationTest < ActiveRecord::TestCase
 coerce_tests! :test_types_of_virtual_columns_are_not_changed_on_round_trip
 def test_types_of_virtual_columns_are_not_changed_on_round_trip_coerced
 author = Author.select("authors.*, 5 as posts_count").first
-dumped = YAML.load(YAML.dump(author))
+dumped_author = YAML.dump(author)
+dumped = YAML.respond_to?(:unsafe_load) ? YAML.unsafe_load(dumped_author) : YAML.load(dumped_author)
 assert_equal 5, author.posts_count
 assert_equal 5, dumped.posts_count
 end
@@ -1207,6 +1208,7 @@ def test_statement_cache_values_differ_coerced
 
 original_test_statement_cache_values_differ
 ensure
+Book.where(author_id: nil, name: 'my book').delete_all
 Book.connection.add_index(:books, [:author_id, :name], unique: true)
 end
 end
@@ -1399,6 +1401,7 @@ class EnumTest < ActiveRecord::TestCase
 
 send(:'original_enums are distinct per class')
 ensure
+Book.where(author_id: nil, name: nil).delete_all
 Book.connection.add_index(:books, [:author_id, :name], unique: true)
 end
 
@@ -1409,6 +1412,7 @@ class EnumTest < ActiveRecord::TestCase
 
 send(:'original_creating new objects with enum scopes')
 ensure
+Book.where(author_id: nil, name: nil).delete_all
 Book.connection.add_index(:books, [:author_id, :name], unique: true)
 end
 
@@ -1419,6 +1423,7 @@ class EnumTest < ActiveRecord::TestCase
 
 send(:'original_enums are inheritable')
 ensure
+Book.where(author_id: nil, name: nil).delete_all
 Book.connection.add_index(:books, [:author_id, :name], unique: true)
 end
 
@@ -1429,6 +1434,7 @@ class EnumTest < ActiveRecord::TestCase
 
 send(:'original_declare multiple enums at a time')
 ensure
+Book.where(author_id: nil, name: nil).delete_all
 Book.connection.add_index(:books, [:author_id, :name], unique: true)
 end
 end
@@ -1522,3 +1528,76 @@ class ReloadModelsTest < ActiveRecord::TestCase
 # `activesupport/lib/active_support/testing/isolation.rb` exceeds what Windows can handle.
 coerce_tests! :test_has_one_with_reload if RbConfig::CONFIG["host_os"] =~ /mswin|mingw/
 end
+
+require "models/post"
+class AnnotateTest < ActiveRecord::TestCase
+# Same as original coerced test except our SQL starts with `EXEC sp_executesql`.
+# TODO: Remove coerce after Rails 7 (see https://.com/rails/rails/pull/42027)
+coerce_tests! :test_annotate_wraps_content_in_an_inline_comment
+def test_annotate_wraps_content_in_an_inline_comment_coerced
+quoted_posts_id, quoted_posts = regexp_escape_table_name("posts.id"), regexp_escape_table_name("posts")
+
+assert_sql(%r{SELECT #{quoted_posts_id} FROM #{quoted_posts} /\* foo \*/}i) do
+posts = Post.select(:id).annotate("foo")
+assert posts.first
+end
+end
+
+# Same as original coerced test except our SQL starts with `EXEC sp_executesql`.
+# TODO: Remove coerce after Rails 7 (see https://.com/rails/rails/pull/42027)
+coerce_tests! :test_annotate_is_sanitized
+def test_annotate_is_sanitized_coerced
+quoted_posts_id, quoted_posts = regexp_escape_table_name("posts.id"), regexp_escape_table_name("posts")
+
+assert_sql(%r{SELECT #{quoted_posts_id} FROM #{quoted_posts} /\* \* /foo/ \* \*/}i) do
+posts = Post.select(:id).annotate("*/foo/*")
+assert posts.first
+end
+
+assert_sql(%r{SELECT #{quoted_posts_id} FROM #{quoted_posts} /\* \*\* //foo// \*\* \*/}i) do
+posts = Post.select(:id).annotate("**//foo//**")
+assert posts.first
+end
+
+assert_sql(%r{SELECT #{quoted_posts_id} FROM #{quoted_posts} /\* \* \* //foo// \* \* \*/}i) do
+posts = Post.select(:id).annotate("* *//foo//* *")
+assert posts.first
+end
+
+assert_sql(%r{SELECT #{quoted_posts_id} FROM #{quoted_posts} /\* \* /foo/ \* \*/ /\* \* /bar \*/}i) do
+posts = Post.select(:id).annotate("*/foo/*").annotate("*/bar")
+assert posts.first
+end
+
+assert_sql(%r{SELECT #{quoted_posts_id} FROM #{quoted_posts} /\* \+ MAX_EXECUTION_TIME\(1\) \*/}i) do
+posts = Post.select(:id).annotate("+ MAX_EXECUTION_TIME(1)")
+assert posts.first
+end
+end
+end
+
+class NestedThroughAssociationsTest < ActiveRecord::TestCase
+# Same as original but replace order with "order(:id)" to ensure that assert_includes_and_joins_equal doesn't raise
+# "A column has been specified more than once in the order by list"
+# Example: original test generate queries like "ORDER BY authors.id, [authors].[id]". We don't support duplicate columns in the order list
+coerce_tests! :test_has_many_through_has_many_with_has_many_through_habtm_source_reflection_preload_via_joins, :test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection_preload_via_joins
+def test_has_many_through_has_many_with_has_many_through_habtm_source_reflection_preload_via_joins_coerced
+# preload table schemas
+Author.joins(:category_post_comments).first
+
+assert_includes_and_joins_equal(
+Author.where("comments.id" => comments(:does_it_hurt).id).order(:id),
+[authors(:david), authors(:mary)], :category_post_comments
+)
+end
+
+def test_has_many_through_has_and_belongs_to_many_with_has_many_source_reflection_preload_via_joins_coerced
+# preload table schemas
+Category.joins(:post_comments).first
+
+assert_includes_and_joins_equal(
+Category.where("comments.id" => comments(:more_greetings).id).order(:id),
+[categories(:general), categories(:technology)], :post_comments
+)
+end
+end