Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/5268~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/5268
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 31, 2025

  1. Relax assertion in finding correct GiST parent 

    Commit 28d3c2d introduced an assertion that if the memorized
downlink location in the insertion stack isn't valid, the parent's LSN
should've changed too. Turns out that was too strict. In
gistFindCorrectParent(), if we walk right, we update the parent's
block number and clear its memorized 'downlinkoffnum'. That triggered
the assertion on next call to gistFindCorrectParent(), if the parent
needed to be split too. Relax the assertion, so that it's OK if
downlinkOffnum is InvalidOffsetNumber.

Back to v12, like commit 28d3c2d

Discussion: https://www.postgresql.org/message-id/[email protected]
    @hlinnaka
    hlinnaka authored and Commitfest Bot committedMar 31, 2025
    Configuration menu
    Copy the full SHA
    ba39946View commit details
    Browse the repository at this point in the history

  2. [CF 5268] Fix incorrect Assert in gistFindCorrectParent() 

    This branch was automatically generated by a robot using es from an
email thread registered at:

https://commitfest.postgresql.org//5268

The branch will be overwritten each time a new  version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

(es): https://www.postgresql.org/message-id/[email protected]
Author(s):
    Commitfest Bot committedMar 31, 2025
    Configuration menu
    Copy the full SHA
    f71ed3eView commit details
    Browse the repository at this point in the history
Loading