Remove preferences dependency from USourceGen unit

Modified TSourceGen.UnitAsString to get information aboute compiler warnings via a new parameters instead of from the Preferences object. This was the only dependency on the Preferences object in the unit. Calling code was modified to pass the required warnings to TSourceGen.UnitAsString as a parameter. This calling code now gets the value from the preferences object. Fixes #167

Author: delphidabbler

Src/USaveUnitMgr.pas

@@ -217,6 +217,7 @@ function TSaveUnitMgr.GenerateSource(const CommentStyle: TCommentStyle;
 begin
 Result := fSourceGen.UnitAsString(
 UnitName,
+Preferences.Warnings,
 CommentStyle,
 TruncateComments,
 Preferences.TruncateSourceComments,

Src/USourceGen.pas

@@ -18,9 +18,14 @@ interface
 
 uses
 // Delphi
-Classes, Generics.Collections,
+Classes,
+Generics.Collections,
 // Project
-ActiveText.UMain, DB.USnippet, UBaseObjects, UIStringList;
+ActiveText.UMain,
+DB.USnippet,
+UBaseObjects,
+UIStringList,
+UWarnings;
 
 
 type
@@ -211,7 +216,7 @@ TSourceGen = class(TObject)
 /// <param name="HeaderComments"><c>IStringList</c> [in] List of comments
 /// to be included at top of unit.</param>
 /// <returns><c>string</c>. Unit source code.</returns>
-function UnitAsString(const UnitName: string;
+function UnitAsString(const UnitName: string; const Warnings: IWarnings;
 const CommentStyle: TCommentStyle = csNone;
 const TruncateComments: Boolean = False;
 const UseCommentsInImplementation: Boolean = False;
@@ -255,10 +260,16 @@ implementation
 
 uses
 // Delphi
-SysUtils, Character,
+SysUtils,
+Character,
 // Project
-ActiveText.UTextRenderer, DB.USnippetKind, UConsts, UExceptions, UPreferences,
-USnippetValidator, UStrUtils, UWarnings, Hiliter.UPasLexer;
+ActiveText.UTextRenderer,
+DB.USnippetKind,
+UConsts,
+UExceptions,
+USnippetValidator,
+UStrUtils,
+Hiliter.UPasLexer;
 
 
 const
@@ -588,14 +599,14 @@ class function TSourceGen.IsFileNameValidUnitName(const FileName: string):
 end;
 
 function TSourceGen.UnitAsString(const UnitName: string;
+const Warnings: IWarnings;
 const CommentStyle: TCommentStyle = csNone;
 const TruncateComments: Boolean = False;
 const UseCommentsInImplementation: Boolean = False;
 const HeaderComments: IStringList = nil): string;
 var
 Writer: TStringBuilder; // used to build source code string
 Snippet: TSnippet; // reference to a snippet object
-Warnings: IWarnings; // object giving info about any inhibited warnings
 ImplCommentStyle: TCommentStyle; // style of comments in implementation
 begin
 // Set comment style for implementation section
@@ -620,7 +631,6 @@ function TSourceGen.UnitAsString(const UnitName: string;
 Writer.AppendLine;
 
 // any conditional compilation symbols
-Warnings := Preferences.Warnings;
 if Warnings.Enabled and not Warnings.IsEmpty then
 begin
 Writer.Append(Warnings.Render);

Src/UTestUnit.pas

@@ -65,7 +65,13 @@ implementation
 // Delphi
 SysUtils,
 // Project
-DB.USnippetKind, UEncodings, UIOUtils, USourceGen, USystemInfo, UUnitAnalyser,
+DB.USnippetKind,
+UEncodings,
+UIOUtils,
+UPreferences,
+USourceGen,
+USystemInfo,
+UUnitAnalyser,
 UUtils;
 
 
@@ -89,7 +95,7 @@ function TTestUnit.GenerateUnitSource: string;
 Generator.IncludeSnippet(fSnippet);
 // Must use Self.UnitName below for Delphis that defined TObject.UnitName
 // otherwise the TObject version is used.
-Result := Generator.UnitAsString(Self.UnitName);
+Result := Generator.UnitAsString(Self.UnitName, Preferences.Warnings);
 finally
 Generator.Free;
 end;