From f5da3d85b95640ac754ee14c47aeb90003e6d7c0 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 6 Feb 2023 22:39:48 +0100 Subject: [PATCH] Fix up outdated comments The existing comments in load_relcache_init_file() were not flexible when new entries were added at the end, so they ended up a bit wrong. Simplify the comments to avoid this issue. --- src/backend/utils/cache/relcache.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c index dfda0ab7d6..b57a20c86e 100644 --- a/src/backend/utils/cache/relcache.c +++ b/src/backend/utils/cache/relcache.c @@ -6141,7 +6141,7 @@ load_relcache_init_file(bool shared) if (rel->rd_isnailed) nailed_indexes++; - /* next, read the pg_index tuple */ + /* read the pg_index tuple */ if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) goto read_failed; @@ -6172,7 +6172,7 @@ load_relcache_init_file(bool shared) */ InitIndexAmRoutine(rel); - /* next, read the vector of opfamily OIDs */ + /* read the vector of opfamily OIDs */ if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) goto read_failed; @@ -6182,7 +6182,7 @@ load_relcache_init_file(bool shared) rel->rd_opfamily = opfamily; - /* next, read the vector of opcintype OIDs */ + /* read the vector of opcintype OIDs */ if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) goto read_failed; @@ -6192,7 +6192,7 @@ load_relcache_init_file(bool shared) rel->rd_opcintype = opcintype; - /* next, read the vector of support procedure OIDs */ + /* read the vector of support procedure OIDs */ if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) goto read_failed; support = (RegProcedure *) MemoryContextAlloc(indexcxt, len); @@ -6201,7 +6201,7 @@ load_relcache_init_file(bool shared) rel->rd_support = support; - /* next, read the vector of collation OIDs */ + /* read the vector of collation OIDs */ if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) goto read_failed; @@ -6211,7 +6211,7 @@ load_relcache_init_file(bool shared) rel->rd_indcollation = indcollation; - /* finally, read the vector of indoption values */ + /* read the vector of indoption values */ if (fread(&len, 1, sizeof(len), fp) != sizeof(len)) goto read_failed; @@ -6221,7 +6221,7 @@ load_relcache_init_file(bool shared) rel->rd_indoption = indoption; - /* finally, read the vector of opcoptions values */ + /* read the vector of opcoptions values */ rel->rd_opcoptions = (bytea **) MemoryContextAllocZero(indexcxt, sizeof(*rel->rd_opcoptions) * relform->relnatts); -- 2.30.2