From 23d7562018b2c772aec26f4641de211d8a930b26 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 19 Jan 2025 14:00:22 -0500 Subject: [PATCH] Remove PrintBufferDescs() and PrintPinnedBufs(). These have been #ifdef'd out for a long time, and in fact have been uncompilable since commit 48354581a of 2016-04-10. The fact that nobody noticed for so long demonstrates their lack of usefulness, so let's remove them rather than fix them. Author: Jacob Brazeal Discussion: https://postgr.es/m/CA+COZaB+9CN_f63PPRoVhHjYmCwwmb_9CWLxqCJdMWDqs1a-JA@mail.gmail.com --- src/backend/storage/buffer/bufmgr.c | 58 ----------------------------- src/include/storage/bufmgr.h | 4 -- 2 files changed, 62 deletions(-) diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index 739daa1153a..0d8849bf894 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -4412,64 +4412,6 @@ DropDatabaseBuffers(Oid dbid) } } -/* ----------------------------------------------------------------- - * PrintBufferDescs - * - * this function prints all the buffer descriptors, for debugging - * use only. - * ----------------------------------------------------------------- - */ -#ifdef NOT_USED -void -PrintBufferDescs(void) -{ - int i; - - for (i = 0; i < NBuffers; ++i) - { - BufferDesc *buf = GetBufferDescriptor(i); - Buffer b = BufferDescriptorGetBuffer(buf); - - /* theoretically we should lock the bufhdr here */ - elog(LOG, - "[%02d] (freeNext=%d, rel=%s, " - "blockNum=%u, flags=0x%x, refcount=%u %d)", - i, buf->freeNext, - relpathbackend(BufTagGetRelFileLocator(&buf->tag), - INVALID_PROC_NUMBER, BufTagGetForkNum(&buf->tag)), - buf->tag.blockNum, buf->flags, - buf->refcount, GetPrivateRefCount(b)); - } -} -#endif - -#ifdef NOT_USED -void -PrintPinnedBufs(void) -{ - int i; - - for (i = 0; i < NBuffers; ++i) - { - BufferDesc *buf = GetBufferDescriptor(i); - Buffer b = BufferDescriptorGetBuffer(buf); - - if (GetPrivateRefCount(b) > 0) - { - /* theoretically we should lock the bufhdr here */ - elog(LOG, - "[%02d] (freeNext=%d, rel=%s, " - "blockNum=%u, flags=0x%x, refcount=%u %d)", - i, buf->freeNext, - relpathperm(BufTagGetRelFileLocator(&buf->tag), - BufTagGetForkNum(&buf->tag)), - buf->tag.blockNum, buf->flags, - buf->refcount, GetPrivateRefCount(b)); - } - } -} -#endif - /* --------------------------------------------------------------------- * FlushRelationBuffers * diff --git a/src/include/storage/bufmgr.h b/src/include/storage/bufmgr.h index 3fdd29bd0b6..46b4e0d90f3 100644 --- a/src/include/storage/bufmgr.h +++ b/src/include/storage/bufmgr.h @@ -275,10 +275,6 @@ extern void DropDatabaseBuffers(Oid dbid); extern bool BufferIsPermanent(Buffer buffer); extern XLogRecPtr BufferGetLSNAtomic(Buffer buffer); - -#ifdef NOT_USED -extern void PrintPinnedBufs(void); -#endif extern void BufferGetTag(Buffer buffer, RelFileLocator *rlocator, ForkNumber *forknum, BlockNumber *blknum); -- 2.30.2