Refactor tidstore.c iterator buffering.
authorThomas Munro <[email protected]>
Wed, 24 Jul 2024 05:24:59 +0000 (17:24 +1200)
committerThomas Munro <[email protected]>
Wed, 24 Jul 2024 05:32:35 +0000 (17:32 +1200)
commitf6bef362cac8c47137f9786171eaee5a95fb538b
tree3fbf2bb88476cd34c5a8d553f24425f2086061e9
parent1462aad2e4474ab61174f8ab00992cd3d6d57c7b
Refactor tidstore.c iterator buffering.

Previously, TidStoreIterateNext() would expand the set of offsets for
each block into an internal buffer that it overwrote each time.  In
order to be able to collect the offsets for multiple blocks before
working with them, change the contract.  Now, the offsets are obtained
by a separate call to TidStoreGetBlockOffsets(), which can be called at
a later time.  TidStoreIteratorResult objects are safe to copy and store
in a queue.

Reviewed-by: Noah Misch <[email protected]>
Discussion: https://postgr.es/m/CAAKRu_bbkmwAzSBgnezancgJeXrQZXy4G4kBTd+5=cr86H5yew@mail.gmail.com
src/backend/access/common/tidstore.c
src/backend/access/heap/vacuumlazy.c
src/include/access/tidstore.h
src/test/modules/test_tidstore/test_tidstore.c