Parse libpq's "keepalives" option more like other integer options.
authorTom Lane <[email protected]>
Wed, 2 Oct 2024 21:30:36 +0000 (17:30 -0400)
committerTom Lane <[email protected]>
Wed, 2 Oct 2024 21:30:36 +0000 (17:30 -0400)
commit920d51979a99df29112396b2c75da7921ba7a7b0
treec1b1019b77b374e41ddc13abe983ce903ef4f03d
parentd94cf5ca7fad9cd81af5eac491bfbaf0facb9f6f
Parse libpq's "keepalives" option more like other integer options.

Use pqParseIntParam (nee parse_int_param) instead of using strtol
directly.  This allows trailing whitespace, which the previous coding
didn't, and makes the spelling of the error message consistent with
other similar cases.

This seems to be an oversight in commit e7a221797, which introduced
parse_int_param.  That fixed places that were using atoi(), but missed
this place which was randomly using strtol() instead.

Ordinarily I'd consider this minor cleanup not worth back-ing.
However, it seems that ecpg assumes it can add trailing whitespace
to URL parameters, so that use of the keepalives option fails in
that context.  Perhaps that's worth improving as a separate matter.
In the meantime, back- this to all supported branches.

Yuto Sasaki (some further cleanup by me)

Discussion: https://postgr.es/m/TY2PR01MB36286A7B97B9A15793335D18C1772@TY2PR01MB3628.jpnprd01.prod.outlook.com
src/interfaces/libpq/fe-connect.c