Fix Y2038 issues with MyStartTime.
authorNathan Bossart <[email protected]>
Mon, 7 Oct 2024 18:51:03 +0000 (13:51 -0500)
committerNathan Bossart <[email protected]>
Mon, 7 Oct 2024 18:51:03 +0000 (13:51 -0500)
commit5d6187d2a28326b3414c394ec4c28c51bb513c44
tree50be6bb91099a0d46126a07d08e64530d940e6b9
parentf391d9dc93a24923c57bb0e044161d3f0b840770
Fix Y2038 issues with MyStartTime.

Several places treat MyStartTime as a "long", which is only 32 bits
wide on some platforms.  In reality, MyStartTime is a pg_time_t,
i.e., a signed 64-bit integer.  This will lead to interesting bugs
on the aforementioned systems in 2038 when signed 32-bit integers
are no longer sufficient to store Unix time (e.g., "pg_ctl start"
hanging).  To fix, ensure that MyStartTime is handled as a 64-bit
value everywhere.  (Of course, users will need to ensure that
time_t is 64 bits wide on their system, too.)

Co-authored-by: Max Johnson
Discussion: https://postgr.es/m/CO1PR07MB905262E8AC270FAAACED66008D682%40CO1PR07MB9052.namprd07.prod.outlook.com
Back-through: 12
contrib/postgres_fdw/option.c
src/backend/utils/error/csvlog.c
src/backend/utils/error/elog.c
src/backend/utils/error/jsonlog.c
src/backend/utils/init/miscinit.c
src/bin/pg_ctl/pg_ctl.c