Remove dependence on -fwrapv semantics in jsonb.
authorNathan Bossart <[email protected]>
Fri, 16 Aug 2024 16:24:44 +0000 (11:24 -0500)
committerNathan Bossart <[email protected]>
Fri, 16 Aug 2024 16:24:44 +0000 (11:24 -0500)
commit108d2adb9e9e084cd57bf514d06ef4b954719ffa
tree761375cd60256cba90448bf1689b742c757e97b7
parent95b856de23c72bbb46b7c5430fa6897002d2908e
Remove dependence on -fwrapv semantics in jsonb.

This commit updates a couple of places in the jsonb code to no
longer rely on signed integer wrapping for correctness.  Like
commit 9e9a2b7031, this is intended to move us closer towards
removing -fwrapv, which may enable some compiler optimizations.
However, there is presently no plan to actually remove that
compiler option in the near future.

This commit makes use of the newly introduced pg_abs_s32() routine
to negate a signed integer (that is known to be negative) for
comparison with an unsigned integer.  In passing, change one use of
INT_MIN to the more portable PG_INT32_MIN.

Reported-by: Alexander Lakhin
Author: Joseph Koshakow
Reviewed-by: Jian He
Discussion: https://postgr.es/m/CAAvxfHdBPOyEGS7s%2Bxf4iaW0-cgiq25jpYdWBqQqvLtLe_t6tw%40mail.gmail.com
src/backend/utils/adt/jsonfuncs.c
src/test/regress/expected/jsonb.out
src/test/regress/sql/jsonb.sql