createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate
authorMichael Paquier <[email protected]>
Thu, 27 Feb 2020 02:20:46 +0000 (11:20 +0900)
committerMichael Paquier <[email protected]>
Thu, 27 Feb 2020 02:20:46 +0000 (11:20 +0900)
commit008cf040962c98c7c55d54c28dcb43c3c1d83c92
treec45f3e7093f2b3210d1096fdaa7a7ddd476db657
parent2c0797da2c26dd5574e0d9128887c1fc2a385c25
createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate

The original coding failed to properly quote those arguments, leading to
failures when using quotes in the values used.  As the quoting can be
encoding-sensitive, the connection to the backend needs to be taken
before applying the correct quoting.

Author: Michael Paquier
Reviewed-by: Daniel Gustafsson
Discussion: https://postgr.es/m/20200214041004[email protected]
Back-through: 9.5
src/bin/scripts/createdb.c
src/bin/scripts/t/020_createdb.pl