check_postgres.git
8 years agoFix "values are not the same" error in replicate_row when repinfo value is a '0'
glynastill [Thu, 16 Apr 2015 16:24:10 +0000 (17:24 +0100)]
Fix "values are not the same" error in replicate_row when repinfo value is a '0'

When check_replicate_row tested for valid values before starting the check, if the actual value returned was 0 it would evaluate to false, resulting in the error:
"Cannot test replication: values are not the same"

This is resolved by simply checking if the value is defined before assigning it's value a blank string instead.

8 years agoRemove four more /o flags
Christoph Berg [Tue, 31 May 2016 20:18:32 +0000 (22:18 +0200)]
Remove four more /o flags

8 years agoremoved 'o' modifier from regular expressions
Martin von Oertzen [Fri, 27 May 2016 12:19:39 +0000 (14:19 +0200)]
removed 'o' modifier from regular expressions

http://stackoverflow.com/questions/550258/does-the-o-modifier-for-perl-regular-expressions-still-provide-any-benefit

8 years agoKeep using pg_relation_size on 8.4 and earlier
Christoph Berg [Tue, 31 May 2016 19:33:01 +0000 (21:33 +0200)]
Keep using pg_relation_size on 8.4 and earlier

pg_indexes_size doesn't exist either on 8.4, but that action is new, so
let's not care for now.

Also fix t/05_docs.t for the newly added actions.

8 years agotxn_idle: if seconds are -0, use 0
Christoph Berg [Tue, 31 May 2016 19:09:43 +0000 (21:09 +0200)]
txn_idle: if seconds are -0, use 0

Close: #75

8 years agoChange table_size to use pg_table_size()
Christoph Berg [Tue, 31 May 2016 18:55:45 +0000 (20:55 +0200)]
Change table_size to use pg_table_size()

Change table_size to use pg_table_size(), i.e. to include the TOAST
table size in the numbers reported. Add new actions indexes_size and
total_relation_size, using the respective pg_indexes_size() and
pg_total_relation_size() functions. All size checks will now also check
materialized views where applicable.

Close: #32, #83

8 years agoAdd changelog entry for Correct extra space in perfdata
Christoph Berg [Thu, 26 May 2016 17:42:14 +0000 (19:42 +0200)]
Add changelog entry for Correct extra space in perfdata

Close #80

8 years agoCorrect extra space in perfdata
Adrien nayrat [Thu, 13 Nov 2014 13:02:39 +0000 (14:02 +0100)]
Correct extra space in perfdata

The extra space result in two spaces between the metrics and its incorrectly parse by centreon.

8 years agoAdd changelog entry for last commit, and close #72
Christoph Berg [Thu, 26 May 2016 16:01:18 +0000 (18:01 +0200)]
Add changelog entry for last commit, and close #72

8 years agoDon't fail when query contains 'disabled' word
Marco Nenciarini [Tue, 12 Aug 2014 08:27:17 +0000 (10:27 +0200)]
Don't fail when query contains 'disabled' word

If a query contains the disabled word (.e.g. select 1 as disabled) "check_postgres.pl --action txn_idle" exits with

```UNKNOWN: No queries - is stats_command_string or track_activities off?```

If you set track_activities to off, the status field contains 'disabled' (at least on 9.3)

8 years agoAdd changelog entries to close #99 and #106
Christoph Berg [Thu, 26 May 2016 12:20:56 +0000 (14:20 +0200)]
Add changelog entries to close #99 and #106

8 years agoCall psql with option -X
Peter Eisentraut [Sat, 30 Jan 2016 23:11:16 +0000 (18:11 -0500)]
Call psql with option -X

Starting in PostgreSQL 9.6, psql -c no longer implies -X, so it has to
be added explicitly in order to avoid customizations in .psqlrc
interfering with the output parsing.

8 years agoRun "make html"
Christoph Berg [Thu, 26 May 2016 11:59:18 +0000 (13:59 +0200)]
Run "make html"

"make html" had not been run for some time, do that now.

8 years agoMerge pull request #106 from mhagander/postgresql.org_https
Christoph Berg [Thu, 26 May 2016 11:57:00 +0000 (13:57 +0200)]
Merge pull request #106 from mhagander/postgresql.org_https

Update URLs to www.postgresql.org to be https

8 years agoUpdate URLs to www.postgresql.org to be https
Magnus Hagander [Wed, 25 May 2016 09:44:37 +0000 (11:44 +0200)]
Update URLs to www.postgresql.org to be https

The main PostgreSQL website is now https only. The versions.rss check
still works by following the redirect, but it's more efficient to hit
the https URL directly.

In passing, also update all the direct links in the documentation to be
https.

9 years agoAdd new argument, --audit-file-dir, to allow control of which directory the same...
Greg Sabino Mullane [Tue, 15 Dec 2015 15:18:38 +0000 (10:18 -0500)]
Add new argument, --audit-file-dir, to allow control of which directory the same-schema action will use to store its files.

9 years agoAdd some minor casting to help with the bloat query.
Greg Sabino Mullane [Mon, 2 Nov 2015 15:34:19 +0000 (10:34 -0500)]
Add some minor casting to help with the bloat query.

9 years agot/02_disk_space.t: relax filesystem check
Christoph Berg [Sat, 29 Aug 2015 21:03:43 +0000 (23:03 +0200)]
t/02_disk_space.t: relax filesystem check

In https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790231, Daniel
Schepler reports pbuilder (a throwaway-minimal-chroot build wrapper for
Debian packages) to setup the filesystem name to be shown as "-". Allow
this in the testsuite.

9 years agoAdd test for --action=wal_files --lsfunc
Christoph Berg [Fri, 17 Jul 2015 20:29:30 +0000 (22:29 +0200)]
Add test for --action=wal_files --lsfunc

9 years agoAllow a wrapper function for wal_files and archive_ready as a non-superuser.
Joshua Elsasser [Fri, 8 May 2015 17:06:29 +0000 (10:06 -0700)]
Allow a wrapper function for wal_files and archive_ready as a non-superuser.

The wrapper function around pg_ls_dir() must hardcode the pg_xlog or
pgxlog/archive_status path, and should take no arguments. It must be
created as a superuser with SECURITY DEFINER.

9 years agoFix hot_standby_delay against a log-shipping (non-) replica.
Joshua Elsasser [Tue, 7 Jul 2015 22:42:39 +0000 (15:42 -0700)]
Fix hot_standby_delay against a log-shipping (non-) replica.

9 years agoset_translations.pl: Write output for all known languages
Christoph Berg [Thu, 16 Jul 2015 10:39:57 +0000 (12:39 +0200)]
set_translations.pl: Write output for all known languages

set_translations.pl only wrote output for languages seen in .po files,
dropping other previously known languages.

Also, fix output to honor the current indentation style (no tabs). In
order to change the current formatting as little as possible, set the
minimal output key output width to 14, and no not append a space after
'key' ('checkcluster-nomrtg' is otherwise too long).

9 years agoRemove duplicated 'es' section
Christoph Berg [Wed, 15 Jul 2015 08:26:19 +0000 (10:26 +0200)]
Remove duplicated 'es' section

... and note author of last commit in changelog

9 years agoAdd complete spanish (es) message translations
Luis Vazquez [Tue, 14 Jul 2015 18:27:49 +0000 (15:27 -0300)]
Add complete spanish (es) message translations

9 years agoSignatures for version 2.22.0 2.22.0
Greg Sabino Mullane [Tue, 30 Jun 2015 15:56:49 +0000 (11:56 -0400)]
Signatures for version 2.22.0

9 years agoLet's release
Greg Sabino Mullane [Tue, 30 Jun 2015 15:35:06 +0000 (11:35 -0400)]
Let's release

9 years agoNo tabs please
Greg Sabino Mullane [Tue, 30 Jun 2015 15:30:25 +0000 (11:30 -0400)]
No tabs please

9 years agoBump version to 2.22.0
Greg Sabino Mullane [Tue, 30 Jun 2015 15:29:59 +0000 (11:29 -0400)]
Bump version to 2.22.0

9 years agoPlaceholders for French translation strings
Greg Sabino Mullane [Tue, 30 Jun 2015 15:27:35 +0000 (11:27 -0400)]
Placeholders for French translation strings

9 years agoMerge branch 'master' of bucardo.org:/var/lib/git/check_postgres
Greg Sabino Mullane [Fri, 26 Jun 2015 14:12:09 +0000 (10:12 -0400)]
Merge branch 'master' of bucardo.org:/var/lib/git/check_postgres

9 years agoSpelling
Greg Sabino Mullane [Fri, 26 Jun 2015 13:18:02 +0000 (09:18 -0400)]
Spelling

9 years agoRearrange recent changes in rough priority order
Greg Sabino Mullane [Fri, 26 Jun 2015 12:52:32 +0000 (08:52 -0400)]
Rearrange recent changes in rough priority order

9 years agoFix txn_time regression test for 9.0/9.1
Christoph Berg [Tue, 23 Jun 2015 14:35:31 +0000 (16:35 +0200)]
Fix txn_time regression test for 9.0/9.1

Newer versions will show the last or current query here, older versions
will just show "<IDLE> in transaction" if there is currently no
query running.

9 years agoFix t/02_sequence.t for PG 9.0/1
Christoph Berg [Tue, 23 Jun 2015 14:26:10 +0000 (16:26 +0200)]
Fix t/02_sequence.t for PG 9.0/1

9 years agoUpdate release notes a bit
Greg Sabino Mullane [Tue, 23 Jun 2015 13:16:26 +0000 (09:16 -0400)]
Update release notes a bit

9 years agoVersion bump.
Greg Sabino Mullane [Tue, 23 Jun 2015 13:09:07 +0000 (09:09 -0400)]
Version bump.

9 years agoRemove tabs, cleanup whitespace
Greg Sabino Mullane [Wed, 27 May 2015 02:02:30 +0000 (22:02 -0400)]
Remove tabs, cleanup whitespace

10 years agoBump copyright
Greg Sabino Mullane [Fri, 8 May 2015 03:54:00 +0000 (23:54 -0400)]
Bump copyright

10 years agoFix issues with latest changes to check_sequence and run_command:
glyn [Wed, 15 Apr 2015 09:53:31 +0000 (10:53 +0100)]
Fix issues with latest changes to check_sequence and run_command:

check_sequence - Split big UNION of sequence selects into chunks to avoid overrunning system argument size

run_command - If we have specified a "target" database, skip all others in global targetdb list

10 years agoChange the way tables are quoted in replicate_row.
glynastill [Fri, 20 Dec 2013 13:16:43 +0000 (13:16 +0000)]
Change the way tables are quoted in replicate_row.

Change the way tables are quoted in replicate_row to allow for tables with schema name.

10 years agoAdd tests for "serial" and "smallserial" columns
Christoph Berg [Mon, 23 Mar 2015 15:38:18 +0000 (16:38 +0100)]
Add tests for "serial" and "smallserial" columns

The code was already there, but not covered by tests

10 years agoQuery all sequences per DB in parallel for action=sequence
Christoph Berg [Mon, 23 Mar 2015 14:52:49 +0000 (15:52 +0100)]
Query all sequences per DB in parallel for action=sequence

action=sequence used to open a new session for every sequence checked,
which could be very slow. Fix by creating a single SQL statement using
UNION ALL to query all sequences at once.

10 years agoAllow optional space before 'QUERY PLAN'
Greg Sabino Mullane [Sat, 1 Nov 2014 16:48:49 +0000 (12:48 -0400)]
Allow optional space before 'QUERY PLAN'

10 years agoTweak test, as the output no longer ends where it used to
Greg Sabino Mullane [Sat, 1 Nov 2014 16:47:52 +0000 (12:47 -0400)]
Tweak test, as the output no longer ends where it used to

10 years agoUse Data::Dumper when showing full output on a failed parse, as this is more often...
Greg Sabino Mullane [Sat, 1 Nov 2014 16:17:18 +0000 (12:17 -0400)]
Use Data::Dumper when showing full output on a failed parse, as this is more often than not a complex structure.

10 years agoGrrr...account for trailing whitespace in psql table output
Greg Sabino Mullane [Thu, 30 Oct 2014 22:14:58 +0000 (18:14 -0400)]
Grrr...account for trailing whitespace in psql table output

10 years agoThanks a lot, Postgres. Now featuring whitespace in psql output that has never been...
Greg Sabino Mullane [Thu, 30 Oct 2014 21:09:10 +0000 (17:09 -0400)]
Thanks a lot, Postgres. Now featuring whitespace in psql output that has never been there before.

10 years agoMerge dbname2, host2, etc. into the new array method.
Greg Sabino Mullane [Thu, 30 Oct 2014 21:02:50 +0000 (17:02 -0400)]
Merge dbname2, host2, etc. into the new array method.

10 years agoQuote values in error message when replicate_row fails
Greg Sabino Mullane [Thu, 30 Oct 2014 17:40:36 +0000 (13:40 -0400)]
Quote values in error message when replicate_row fails

10 years agoFix bloat check to use correct SQL depending on the server version.
Christoph Berg [Mon, 8 Sep 2014 15:05:35 +0000 (17:05 +0200)]
Fix bloat check to use correct SQL depending on the server version.

Previously it used the psql version which might differ when multiple
versions are installed locally, or when querying remote servers.

The hot_standby_delay check is also affected, but more involved to fix,
so leave that for later.

Adrian Vondendriesch

10 years agoShow OS on failure-to-parse errors
Greg Sabino Mullane [Mon, 14 Jul 2014 16:52:47 +0000 (12:52 -0400)]
Show OS on failure-to-parse errors

10 years agoWhen we fail to parse the psql output, show the entire output string rather than...
Greg Sabino Mullane [Mon, 14 Jul 2014 16:50:34 +0000 (12:50 -0400)]
When we fail to parse the psql output, show the entire output string rather than just the failing line, to better aid in debugging as recently seen on the list.

10 years agoTweak testing output
Greg Sabino Mullane [Mon, 14 Jul 2014 16:21:26 +0000 (12:21 -0400)]
Tweak testing output

10 years agoImproved multi-slave support in replicate_row.
Andrew Yochum [Thu, 3 Jul 2014 14:15:27 +0000 (10:15 -0400)]
Improved multi-slave support in replicate_row.

10 years agoMerge branch 'space_error' of https://.com/jeffjanes/check_postgres
Greg Sabino Mullane [Thu, 3 Jul 2014 11:24:35 +0000 (07:24 -0400)]
Merge branch 'space_error' of https://.com/jeffjanes/check_postgres

10 years agoMerge branch 'master' of https://.com/terrorobe/check_postgres
Greg Sabino Mullane [Thu, 3 Jul 2014 11:22:39 +0000 (07:22 -0400)]
Merge branch 'master' of https://.com/terrorobe/check_postgres

Conflicts:
check_postgres.pl

10 years agoMerge branch 'query-time-show-query' of https://.com/petere/check_postgres
Greg Sabino Mullane [Thu, 3 Jul 2014 10:53:16 +0000 (06:53 -0400)]
Merge branch 'query-time-show-query' of https://.com/petere/check_postgres

10 years agoDeclare POD encoding to be utf8
Christoph Berg [Thu, 3 Jul 2014 08:31:36 +0000 (10:31 +0200)]
Declare POD encoding to be utf8

10 years agoQuick stub to show port when testing. Always 5432 for now (with a custom socket dir)
Greg Sabino Mullane [Thu, 12 Jun 2014 21:49:51 +0000 (17:49 -0400)]
Quick stub to show port when testing. Always 5432 for now (with a custom socket dir)

10 years agoAdd xact timestamp support to hot_standby_delay
Josh Williams [Thu, 12 Jun 2014 21:24:24 +0000 (17:24 -0400)]
Add xact timestamp support to hot_standby_delay

Allow the hot_standby_delay check to accept xlog byte position or
timestamp lag intervals as thresholds, or even both at the same time.

10 years agoShow actual long-running query in query_time output
Peter Eisentraut [Wed, 11 Jun 2014 20:04:38 +0000 (16:04 -0400)]
Show actual long-running query in query_time output

10 years agofix & extend hot_standby_delay documentation
Michael Renner [Wed, 11 Jun 2014 15:10:33 +0000 (17:10 +0200)]
fix & extend hot_standby_delay documentation

This should also account for all places where the refactoring of
the numbered dbparameters (host2, port2, etc.) was referenced in the
documentation. Drop the TODO entry.

10 years agoMerge branch 'master' of .com:terrorobe/check_postgres
Michael Renner [Wed, 11 Jun 2014 15:08:40 +0000 (17:08 +0200)]
Merge branch 'master' of .com:terrorobe/check_postgres

11 years agoDon't swallow space before the -c flag when reporting errors
Jeff Janes [Wed, 21 May 2014 17:48:01 +0000 (10:48 -0700)]
Don't swallow space before the -c flag when reporting errors

11 years agoQuick TODO item
Greg Sabino Mullane [Mon, 5 May 2014 15:50:39 +0000 (11:50 -0400)]
Quick TODO item

11 years agoStart 2.21.1 notes
Greg Sabino Mullane [Tue, 18 Feb 2014 01:11:20 +0000 (20:11 -0500)]
Start 2.21.1 notes

11 years agoAdd an ORDER BY to the slony_status check to account for cases in which
Jeff Frost [Tue, 18 Feb 2014 01:08:24 +0000 (20:08 -0500)]
Add an ORDER BY to the slony_status check to account for cases in which
there is more than one node in replication; we want to report on the
most lagged server.

11 years ago'no warnings' makes Perl::Critic cry. Try a different way.
Greg Sabino Mullane [Wed, 9 Oct 2013 18:14:05 +0000 (14:14 -0400)]
'no warnings' makes Perl::Critic cry. Try a different way.

11 years ago--host2 and friends no longer work.
David E. Wheeler [Tue, 24 Sep 2013 23:27:22 +0000 (16:27 -0700)]
--host2 and friends no longer work.

11 years agoEliminate some "Use of uninitialized value" warnings.
David E. Wheeler [Tue, 24 Sep 2013 23:22:44 +0000 (16:22 -0700)]
Eliminate some "Use of uninitialized value" warnings.

11 years agoGet rid of number opts in docs.
David E. Wheeler [Tue, 24 Sep 2013 23:20:46 +0000 (16:20 -0700)]
Get rid of number opts in docs.

11 years ago`curl` does not like `=` between an option and its value.
David E. Wheeler [Tue, 24 Sep 2013 22:30:21 +0000 (15:30 -0700)]
`curl` does not like `=` between an option and its value.

This gets the `t/02_new_version_cp.t` to pass on systems that use `curl`.

11 years agoSignatures for 2.21.0
Greg Sabino Mullane [Tue, 24 Sep 2013 19:12:35 +0000 (15:12 -0400)]
Signatures for 2.21.0

11 years agoWhitespace 2.21.0
Greg Sabino Mullane [Tue, 24 Sep 2013 19:10:18 +0000 (15:10 -0400)]
Whitespace

11 years agoRemove the no warnings hack.
Greg Sabino Mullane [Tue, 24 Sep 2013 19:08:30 +0000 (15:08 -0400)]
Remove the no warnings hack.

11 years agoVersion bump, better binmode
Greg Sabino Mullane [Tue, 24 Sep 2013 19:00:04 +0000 (15:00 -0400)]
Version bump, better binmode

11 years agoSpelling tweaks
Greg Sabino Mullane [Tue, 24 Sep 2013 18:58:28 +0000 (14:58 -0400)]
Spelling tweaks

11 years agoVersion bump
Greg Sabino Mullane [Tue, 24 Sep 2013 18:57:59 +0000 (14:57 -0400)]
Version bump

11 years agoSkip a few more files in the manifest
Greg Sabino Mullane [Tue, 24 Sep 2013 18:34:32 +0000 (14:34 -0400)]
Skip a few more files in the manifest

11 years agoSpelling fixes
Greg Sabino Mullane [Mon, 23 Sep 2013 20:22:23 +0000 (16:22 -0400)]
Spelling fixes

11 years agoTypo
Greg Sabino Mullane [Mon, 23 Sep 2013 19:46:09 +0000 (15:46 -0400)]
Typo

11 years agoPerl::Critic insipred fixes
Greg Sabino Mullane [Mon, 23 Sep 2013 19:44:38 +0000 (15:44 -0400)]
Perl::Critic insipred fixes

11 years agoMinor translation fixes
Greg Sabino Mullane [Mon, 23 Sep 2013 19:12:43 +0000 (15:12 -0400)]
Minor translation fixes

11 years agoDocument testsuite, notably the DBD::Pg version required
Christoph Berg [Mon, 23 Sep 2013 13:12:18 +0000 (15:12 +0200)]
Document testsuite, notably the DBD::Pg version required

11 years agoFix regex for cp_version testing.
Greg Sabino Mullane [Sun, 22 Sep 2013 18:53:40 +0000 (14:53 -0400)]
Fix regex for cp_version testing.

11 years agoBump version to 2.20.2
Greg Sabino Mullane [Sun, 22 Sep 2013 18:47:24 +0000 (14:47 -0400)]
Bump version to 2.20.2

11 years agoAdding a jstkind to the dummy pgagent schema, so the recent changes that reference...
Greg Sabino Mullane [Sun, 22 Sep 2013 18:33:44 +0000 (14:33 -0400)]
Adding a jstkind to the dummy pgagent schema, so the recent changes that reference it can work.

11 years agot/02_relation_size.t: Sleep 0.5s for the MRTG test
Christoph Berg [Thu, 19 Sep 2013 10:58:12 +0000 (12:58 +0200)]
t/02_relation_size.t: Sleep 0.5s for the MRTG test

Sleeping 1s created a race condition because we also check after 1s, so
it was only luck whether the result of that check is "1" or "2"

11 years agoFix same_schema check on 9.3 by ignoring relminmxid differences in pg_class
Christoph Berg [Thu, 19 Sep 2013 10:11:06 +0000 (12:11 +0200)]
Fix same_schema check on 9.3 by ignoring relminmxid differences in pg_class

11 years agot/02_slony_status.t: Fix to work with 9.3
Christoph Berg [Thu, 19 Sep 2013 09:48:50 +0000 (11:48 +0200)]
t/02_slony_status.t: Fix to work with 9.3

The error was "schema does not exist" until 9.2, and is now "table does
not exist", so just look for "does not exist".

11 years agoSetting SKIP_NETWORK_TESTS will skip the new_version tests
Christoph Berg [Thu, 19 Sep 2013 09:21:17 +0000 (11:21 +0200)]
Setting SKIP_NETWORK_TESTS will skip the new_version tests

Build daemons for Debian packages might not have network access, so
provide a way to disable the tests depeding on networking

11 years agot/02_last_vacuum.t: Reorder commit calls to make test more stable
Christoph Berg [Thu, 19 Sep 2013 09:10:44 +0000 (11:10 +0200)]
t/02_last_vacuum.t: Reorder commit calls to make test more stable

11 years agoInstall man page in section 1
Christoph Berg [Thu, 19 Sep 2013 09:07:47 +0000 (11:07 +0200)]
Install man page in section 1

Peter Eisentraut, bug 53,  issue 26

11 years agoAdd a changelog entry for the locks fix
Christoph Berg [Wed, 18 Sep 2013 15:44:40 +0000 (17:44 +0200)]
Add a changelog entry for the locks fix

11 years agoSkipping disk_space tests if df doesn't work
Christoph Berg [Wed, 18 Sep 2013 15:37:11 +0000 (17:37 +0200)]
Skipping disk_space tests if df doesn't work

df might fail in chroot environments, e.g. on build daemons where
check-postgres packages are built

11 years agoSort lock types so the output ordering is predicatable
Christoph Berg [Wed, 18 Sep 2013 15:04:38 +0000 (17:04 +0200)]
Sort lock types so the output ordering is predicatable

11 years agoCredit recent change.
Greg Sabino Mullane [Wed, 28 Aug 2013 15:27:05 +0000 (11:27 -0400)]
Credit recent change.

11 years agoUpdate check_postgres.pl
mintsoft [Wed, 28 Aug 2013 09:03:17 +0000 (10:03 +0100)]
Update check_postgres.pl

Fixing issue with SQL steps in check_pgagent_jobs for jobs which perform deletes, these return non-0 yet are still successful.
Behaviour should now be that <>0 on batch is a failure, but only -1 is a failure for sql steps.

11 years agoREADME: Fix two typos
Christoph Berg [Thu, 4 Jul 2013 11:17:57 +0000 (13:17 +0200)]
README: Fix two typos

11 years agot/02_settings_checksum.t: Accept hex digits
Christoph Berg [Tue, 2 Jul 2013 13:27:58 +0000 (15:27 +0200)]
t/02_settings_checksum.t: Accept hex digits

Previously, this check only worked by chance if the returned checksum
started with a plain digit.