From: Andres Freund <andres@anarazel.de>
Date: Wed, 2 Apr 2025 10:56:29 +0000 (-0400)
Subject: tests: Cope with io_method in TEMP_CONFIG in test_aio
X-Git-Tag: REL_18_BETA1~337
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=327d987df1e72a9b146f312df0a5ed34ef148720;p=postgresql.git

tests: Cope with io_method in TEMP_CONFIG in test_aio

If io_method is set in TEMP_CONFIG the test added in 93bc3d75d8e fails,
because it assumes the io_method specified at initdb is actually used.

Fix that by appending the io_method again, after initdb (and thus after
TEMP_CONFIG has been added by Cluster.pm).

Per buildfarm animal bumblebee

Discussion: https://postgr.es/m/zh5u22wbpcyfw2ddl3lsvmsxf4yvsrvgxqwwmfjddc4c2khsgp@gfysyjsaelr5
---

diff --git a/src/test/modules/test_aio/t/001_aio.pl b/src/test/modules/test_aio/t/001_aio.pl
index 93fe5b116df..e8d064ecd8d 100644
--- a/src/test/modules/test_aio/t/001_aio.pl
+++ b/src/test/modules/test_aio/t/001_aio.pl
@@ -94,6 +94,17 @@ log_statement=all
 log_error_verbosity=default
 restart_after_crash=false
 temp_buffers=100
+));
+
+	# Even though we used -c io_method=... above, if TEMP_CONFIG sets
+	# io_method, it'd override the setting persisted at initdb time. While
+	# using (and later verifying) the setting from initdb provides some
+	# verification of having used the io_method during initdb, it's probably
+	# not worth the complication of only appending if the variable is set in
+	# in TEMP_CONFIG.
+	$node->append_conf(
+		'postgresql.conf', qq(
+io_method=$io_method
 ));
 
 	ok(1, "$io_method: initdb");