Fix COPY hangs.

During COPY IN state (i.e. COPY FROM STDIN), frontend can send Flush
or Sync messages.  According to the F/B protocol specification, they
should be ignored but Pgpool-II treated as an invalid message and this
causes COPY hung.

Discussion: https://.com/pgpool/pgpool2/issues/79
Back-through: v4.1

diff --git a/src/protocol/pool_proto_modules.c b/src/protocol/pool_proto_modules.c
index 4988325dcad1de1379dc45f174e6df51d6a37392..9aa0d7736acd18cc3e6917fd21cae1af574ee692 100644 (file)
--- a/src/protocol/pool_proto_modules.c
+++ b/src/protocol/pool_proto_modules.c
@@ -3398,6 +3398,12 @@ CopyDataRows(POOL_CONNECTION * frontend,
                                        copy_count++;
                                        continue;
                                }
+                               /*
+                                * Flush (H) or Sync (S) messages should be ignored while in
+                                * the COPY IN mode.
+                                */
+                               else if (kind == 'H' || kind == 'S')
+                                       continue;
                                else
                                {
                                        if (pool_config->log_client_messages && copy_count != 0)