Remove useless unconstify

Digging into the history, this was not necessary even when it was
added, but might have been some time before that.  In any case, there
is no use for this now.

diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
index 68069fcfd3b59b8af1d31424532e2d3cfb2eabb8..33a810b008d1b251b132e17135463ba0b1a8fea8 100644 (file)
--- a/src/backend/utils/adt/formatting.c
+++ b/src/backend/utils/adt/formatting.c
@@ -2621,7 +2621,7 @@ seq_search_localized(const char *name, char **array, int *len, Oid collid)
     * Fold to upper case, then to lower case, so that we can match reliably
     * even in languages in which case conversions are not injective.
     */
-   upper_name = str_toupper(unconstify(char *, name), strlen(name), collid);
+   upper_name = str_toupper(name, strlen(name), collid);
    lower_name = str_tolower(upper_name, strlen(upper_name), collid);
    pfree(upper_name);