Remove PrintBufferDescs() and PrintPinnedBufs().

These have been #ifdef'd out for a long time, and in fact have
been uncompilable since commit 48354581a of 2016-04-10.  The
fact that nobody noticed for so long demonstrates their lack of
usefulness, so let's remove them rather than fix them.

Author: Jacob Brazeal <[email protected]>
Discussion: https://postgr.es/m/CA+COZaB+9CN_f63PPRoVhHjYmCwwmb_9CWLxqCJdMWDqs1a-JA@mail.gmail.com

diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 739daa1153a64080203df26849a99bf53f6eac86..0d8849bf894fb25ff84fb7fb96b94221b82d8a60 100644 (file)
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -4412,64 +4412,6 @@ DropDatabaseBuffers(Oid dbid)
    }
 }
 
-/* -----------------------------------------------------------------
- *     PrintBufferDescs
- *
- *     this function prints all the buffer descriptors, for debugging
- *     use only.
- * -----------------------------------------------------------------
- */
-#ifdef NOT_USED
-void
-PrintBufferDescs(void)
-{
-   int         i;
-
-   for (i = 0; i < NBuffers; ++i)
-   {
-       BufferDesc *buf = GetBufferDescriptor(i);
-       Buffer      b = BufferDescriptorGetBuffer(buf);
-
-       /* theoretically we should lock the bufhdr here */
-       elog(LOG,
-            "[%02d] (freeNext=%d, rel=%s, "
-            "blockNum=%u, flags=0x%x, refcount=%u %d)",
-            i, buf->freeNext,
-            relpathbackend(BufTagGetRelFileLocator(&buf->tag),
-                           INVALID_PROC_NUMBER, BufTagGetForkNum(&buf->tag)),
-            buf->tag.blockNum, buf->flags,
-            buf->refcount, GetPrivateRefCount(b));
-   }
-}
-#endif
-
-#ifdef NOT_USED
-void
-PrintPinnedBufs(void)
-{
-   int         i;
-
-   for (i = 0; i < NBuffers; ++i)
-   {
-       BufferDesc *buf = GetBufferDescriptor(i);
-       Buffer      b = BufferDescriptorGetBuffer(buf);
-
-       if (GetPrivateRefCount(b) > 0)
-       {
-           /* theoretically we should lock the bufhdr here */
-           elog(LOG,
-                "[%02d] (freeNext=%d, rel=%s, "
-                "blockNum=%u, flags=0x%x, refcount=%u %d)",
-                i, buf->freeNext,
-                relpathperm(BufTagGetRelFileLocator(&buf->tag),
-                            BufTagGetForkNum(&buf->tag)),
-                buf->tag.blockNum, buf->flags,
-                buf->refcount, GetPrivateRefCount(b));
-       }
-   }
-}
-#endif
-
 /* ---------------------------------------------------------------------
  *     FlushRelationBuffers
  *

diff --git a/src/include/storage/bufmgr.h b/src/include/storage/bufmgr.h
index 3fdd29bd0b6eae61e40e61621ab3e167853d0029..46b4e0d90f37b3636824481034011844edadd4be 100644 (file)
--- a/src/include/storage/bufmgr.h
+++ b/src/include/storage/bufmgr.h
@@ -275,10 +275,6 @@ extern void DropDatabaseBuffers(Oid dbid);
 
 extern bool BufferIsPermanent(Buffer buffer);
 extern XLogRecPtr BufferGetLSNAtomic(Buffer buffer);
-
-#ifdef NOT_USED
-extern void PrintPinnedBufs(void);
-#endif
 extern void BufferGetTag(Buffer buffer, RelFileLocator *rlocator,
                         ForkNumber *forknum, BlockNumber *blknum);