Enlarge assertion in bloom_init() for false_positive_rate

false_positive_rate is a parameter that can be set with the bloom
opclass in BRIN, and setting it to a value of exactly 0.25 would trigger
an assertion in the first INSERT done on the index with value set.

The assertion changed here relied on BLOOM_{MIN|MAX}_FALSE_POSITIVE_RATE
that are somewhat arbitrary values, and specifying an out-of-range value
would also trigger a failure when defining such an index.  So, as-is,
the assertion was just doubling on the min-max check of the reloption.
This is now enlarged to check that it is a correct percentage value,
instead, based on a suggestion by Tom Lane.

Author: Alexander Lakhin
Reviewed-by: Tom Lane, Shihao Zhong
Discussion: https://postgr.es/m/17969-a6c54de48026d694@postgresql.org
Back-through: 14

diff --git a/src/backend/access/brin/brin_bloom.c b/src/backend/access/brin/brin_bloom.c
index 56534cf29ccc8237349dc8f6e04eaf890d6dfc41..5bfaffe59b4185083cb2aa218cac537967e35f5b 100644 (file)
--- a/src/backend/access/brin/brin_bloom.c
+++ b/src/backend/access/brin/brin_bloom.c
@@ -320,8 +320,7 @@ bloom_init(int ndistinct, double false_positive_rate)
        int                     nhashes;                /* number of hash functions */
 
        Assert(ndistinct > 0);
-       Assert((false_positive_rate >= BLOOM_MIN_FALSE_POSITIVE_RATE) &&
-                  (false_positive_rate < BLOOM_MAX_FALSE_POSITIVE_RATE));
+       Assert(false_positive_rate > 0 && false_positive_rate < 1);
 
        /* calculate bloom filter size / parameters */
        bloom_filter_size(ndistinct, false_positive_rate,