Use portable diff options in pg_bsd_indent's regression test.

We had been using "diff -upd", which evidently works for most people,
but Solaris's diff doesn't like it.  (We'd not noticed because the
Solaris buildfarm animals weren't running this test until they were
upgraded to the latest buildfarm client script.)  Change to "diff -U3"
which is what pg_regress has used for ages.

Per buildfarm (and off-list discussion with Noah Misch).

Back- to v16 where this test was added.  In v16,
also back- the relevant part of 628c1d1f2 so that
the test script looks about the same in all branches.

diff --git a/src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl b/src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl
index 9e23ab96161bc04b0d0cef528212daa8330b1cd8..d23722a0e008adc55ae9e59e1afb4231e86e76c3 100644 (file)
--- a/src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl
+++ b/src/tools/pg_bsd_indent/t/001_pg_bsd_indent.pl
@@ -26,8 +26,8 @@ program_version_ok('pg_bsd_indent');
 # Any diffs in the generated files will be accumulated here.
 my $diffs_file = "test.diffs";
 
-# options used with diff
-my @diffopts = ("-upd");
+# options used with diff (see pg_regress.c's pretty_diff_opts)
+my @diffopts = ("-U3");
 push(@diffopts, "--strip-trailing-cr") if $windows_os;
 
 # Copy support files to current dir, so *.pro files don't need to know path.